Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 15023019: Fix bug in checked mode: we need to register super fields as well, because the super class might no… (Closed)

Created:
7 years, 7 months ago by ngeoffray
Modified:
7 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in checked mode: we need to register super fields as well, because the super class might not be instantiated. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=22773

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/language/checked_setter_test.dart View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 7 months ago (2013-05-16 07:42:12 UTC) #1
karlklose
LGTM.
7 years, 7 months ago (2013-05-16 07:51:01 UTC) #2
ngeoffray
7 years, 7 months ago (2013-05-16 07:52:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22773 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698