Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15021020: content: Extract url utility functions into url_utils.{h,cc} (Closed)

Created:
7 years, 7 months ago by tfarina
Modified:
7 years, 7 months ago
Reviewers:
asanka, Lei Zhang, Jói
CC:
chromium-reviews, asanka, Avi (use Gerrit), creis+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, ajwong+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : sync+rebase #

Patch Set 3 : fix content_unittests and content_browsertests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -43 lines) Patch
M chrome/browser/download/download_util.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/url_constants.h View 1 2 chunks +0 lines, -10 lines 0 comments Download
M content/public/common/url_constants.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download
A content/public/common/url_utils.h View 1 chunk +27 lines, -0 lines 0 comments Download
A content/public/common/url_utils.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
7 years, 7 months ago (2013-05-16 01:10:24 UTC) #1
Jói
LGTM
7 years, 7 months ago (2013-05-16 01:13:14 UTC) #2
asanka
LGTM. Much better!
7 years, 7 months ago (2013-05-16 15:14:44 UTC) #3
tfarina
TBRing Lei for the rest of chrome/
7 years, 7 months ago (2013-05-17 18:50:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/15021020/8001
7 years, 7 months ago (2013-05-17 18:51:18 UTC) #5
Lei Zhang
lgtm
7 years, 7 months ago (2013-05-17 19:18:13 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 21:17:09 UTC) #7
Message was sent while issue was closed. 
Change committed as 200885

Powered by Google App Engine
This is Rietveld 408576698