Issue 15012010: Remove the CSS_COMPOSITING define, leaving the implementation under the runtime flag, since runtime…

Issue 15012010: Remove the CSS_COMPOSITING define, leaving the implementation under the runtime flag, since runtime… (Closed)

Created:
7 years, 7 months ago by Rik

Modified:
7 years, 7 months ago

Reviewers:
eseidel

CC:
blink-reviews, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove the CSS_COMPOSITING define, leaving the implementation under the runtime flag, since runtime switching of css properties is now in place. BUG=229926 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149989

Patch Set 1 #

Patch Set 2 : removed last CSS_COMPOSITING defines + fixed testexpectations #

Patch Set 3 : Adjusted for latest changes in runtime enabling #

Patch Set 4 : Fixed flaky test #

Patch Set 5 : Fixed bad test #

Patch Set 6 : removed bogus test #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+323 lines, -449 lines)			Patch
M	LayoutTests/TestExpectations	View	1 2 3 4 5	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/css3/compositing/background-blend-mode-property-expected.txt	View	1	1 chunk	+32 lines, -32 lines	0 comments	Download
M	LayoutTests/css3/compositing/background-blend-mode-property-parsing-expected.txt	View	1	1 chunk	+80 lines, -80 lines	0 comments	Download
M	LayoutTests/css3/compositing/blend-mode-property-expected.txt	View	1	1 chunk	+32 lines, -32 lines	0 comments	Download
M	LayoutTests/css3/compositing/blend-mode-property-parsing-expected.txt	View	1	1 chunk	+80 lines, -80 lines	0 comments	Download
M	LayoutTests/css3/compositing/effect-background-blend-mode.html	View	1 2 3 4 5	1 chunk	+0 lines, -42 lines	0 comments	Download
D	LayoutTests/css3/compositing/effect-background-blend-mode-expected.png	View	1 2 3 4 5	Binary file		0 comments	Download
D	LayoutTests/css3/compositing/effect-background-blend-mode-expected.txt	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/css3/compositing/effect-background-blend-mode-stacking.html	View	1 2 3 4 5	1 chunk	+0 lines, -33 lines	0 comments	Download
D	LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.png	View	1 2 3 4 5	Binary file		0 comments	Download
D	LayoutTests/css3/compositing/effect-background-blend-mode-stacking-expected.txt	View	1 2 3 4 5	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/css3/compositing/script-tests/background-blend-mode-property-parsing.js	View	1 2	2 chunks	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/css3/compositing/script-tests/blend-mode-property-parsing.js	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/css3/compositing/should-have-compositing-layer.html	View	1 2 3	1 chunk	+16 lines, -23 lines	0 comments	Download
M	LayoutTests/css3/compositing/should-have-compositing-layer-expected.txt	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	LayoutTests/webexposed/css-properties-as-js-properties-expected.txt	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSComputedStyleDeclaration.cpp	View		4 chunks	+0 lines, -6 lines	0 comments	Download
M	Source/core/css/CSSParser.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/CSSParser.cpp	View	1 2	11 chunks	+9 lines, -24 lines	0 comments	Download
M	Source/core/css/CSSProperty.cpp	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/css/CSSPropertyNames.in	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/DeprecatedStyleBuilder.cpp	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/css/StyleResolver.cpp	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/features.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/page/RuntimeCSSEnabled.cpp	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/core/page/RuntimeEnabledFeatures.in	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderLayer.h	View	1	3 chunks	+2 lines, -10 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	1	6 chunks	+14 lines, -12 lines	0 comments	Download
M	Source/core/rendering/RenderLayerBacking.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderLayerBacking.cpp	View	1	4 chunks	+5 lines, -10 lines	0 comments	Download
M	Source/core/rendering/RenderLayerCompositor.cpp	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyle.h	View		2 chunks	+3 lines, -9 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyle.cpp	View		2 chunks	+24 lines, -5 lines	0 comments	Download
M	Source/core/rendering/style/StyleRareNonInheritedData.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/style/StyleRareNonInheritedData.cpp	View		3 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cabanier@adobe.com/15012010/1

7 years, 7 months ago (2013-05-07 22:08:59 UTC) #2

commit-bot: I haz the power

Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7130

7 years, 7 months ago (2013-05-07 23:25:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cabanier@adobe.com/15012010/30001

7 years, 7 months ago (2013-05-08 21:06:48 UTC) #4

Message was sent while issue was closed.

Change committed as 149989

Expand Messages | Collapse Messages