Issue 14985009: <label> element should send key and focus events if it has contenteditable attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14985009: <label> element should send key and focus events if it has contenteditable attribute. (Closed)

Created:
7 years, 7 months ago by yael.aharon

Modified:
7 years, 7 months ago

Reviewers:
tkent, yael.aharon1, eseidel

CC:
blink-reviews, eae+blinkwatch, ojan, Julie Parent

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

<label> element should send key and focus events if it has contenteditable attribute. HTMLLabelElement should be focusable if it passes the test isContentEditable(). As a result, the proper events would be sent. Both Opera and Firefox support this behavior. BUG=209871 TEST=fast/forms/label/labels-contenteditable.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149973

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -1 line)			Patch
A	LayoutTests/fast/forms/label/labels-contenteditable.html	View	1 chunk	+52 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/forms/label/labels-contenteditable-expected.txt	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/forms/resources/label-test-util.js	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLLabelElement.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14985009/1

7 years, 7 months ago (2013-05-08 19:58:33 UTC) #3

Message was sent while issue was closed.

Change committed as 149973

Expand Messages | Collapse Messages