Source/core/html/HTMLLabelElement.cpp - Issue 14985009: <label> element should send key and focus events if it has contenteditable attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLLabelElement.cpp

Issue 14985009: <label> element should send key and focus events if it has contenteditable attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLLabelElement.cpp

diff --git a/Source/core/html/HTMLLabelElement.cpp b/Source/core/html/HTMLLabelElement.cpp

index 5f69302e1bd17432b16e906b52717ebbc13cf024..c1ce7601e0ed38adb60e6bdbcf4fd06ba7e6a5ca 100644

--- a/Source/core/html/HTMLLabelElement.cpp

+++ b/Source/core/html/HTMLLabelElement.cpp

@@ -66,7 +66,8 @@ PassRefPtr<HTMLLabelElement> HTMLLabelElement::create(const QualifiedName& tagNa

bool HTMLLabelElement::isFocusable() const

{

- return false;

+ HTMLLabelElement* that = const_cast<HTMLLabelElement*>(this);

+ return that->isContentEditable();

}

LabelableElement* HTMLLabelElement::control()

« no previous file with comments | « LayoutTests/fast/forms/resources/label-test-util.js ('k') | no next file » | no next file with comments »