Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 14977010: Android: implement content::Shell::Close() (Closed)

Created:
7 years, 7 months ago by Sami
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Android: implement content::Shell::Close() This patch implements the Shell::Close() method for Content Shell on Android. BUG=138226 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M content/shell/android/java/src/org/chromium/content_shell/ShellManager.java View 2 chunks +12 lines, -6 lines 0 comments Download
M content/shell/android/shell_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/android/shell_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/shell/shell_android.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Sami
Hi Ted. This implements the Close() method we talked about. Turns out it's not strictly ...
7 years, 7 months ago (2013-05-13 15:08:07 UTC) #1
Sami
Since Ted is out, would you mind having a peek at this Yaron?
7 years, 7 months ago (2013-05-15 17:14:42 UTC) #2
Yaron
+dtrain
7 years, 7 months ago (2013-05-15 22:16:10 UTC) #3
David Trainor- moved to gerrit
lgtm
7 years, 7 months ago (2013-05-15 22:22:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/14977010/1
7 years, 7 months ago (2013-05-16 10:46:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=3269
7 years, 7 months ago (2013-05-16 10:56:01 UTC) #6
Sami
Yaron, may I have your rubber-stamp for content/shell/android? pfeldman@, please see content/shell_android.cc.
7 years, 7 months ago (2013-05-16 11:27:12 UTC) #7
Sami
Friendly ping, thanks!
7 years, 6 months ago (2013-05-28 09:43:07 UTC) #8
Yaron
rubberstamp lgtm sorry about that
7 years, 6 months ago (2013-05-28 16:11:47 UTC) #9
Ted C
lgtm
7 years, 6 months ago (2013-05-28 16:56:21 UTC) #10
Sami
Thanks guys. I think I just need the OK from Pavel now.
7 years, 6 months ago (2013-05-28 17:23:31 UTC) #11
jochen (gone - plz use gerrit)
lgtm
7 years, 6 months ago (2013-05-28 19:00:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/14977010/1
7 years, 6 months ago (2013-05-29 09:53:40 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-05-29 12:41:53 UTC) #14
Message was sent while issue was closed.
Change committed as 202852

Powered by Google App Engine
This is Rietveld 408576698