content/shell/shell_android.cc - Issue 14977010: Android: implement content::Shell::Close()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/shell_android.cc

Issue 14977010: Android: implement content::Shell::Close() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/shell_android.cc

diff --git a/content/shell/shell_android.cc b/content/shell/shell_android.cc

index d8a6fcbbfc7df78d11746dbbfbabfdb760d8da90..d12d0d7a09e9fdc18eac615ff6dc5c1a87fb6f18 100644

--- a/content/shell/shell_android.cc

+++ b/content/shell/shell_android.cc

@@ -80,8 +80,9 @@ bool Shell::PlatformIsFullscreenForTabOrPending(

}

void Shell::Close() {

- // TODO(tedchoc): Implement Close method for android shell

- NOTIMPLEMENTED();

+ CloseShellView(java_object_.obj());

+ java_object_.Reset();

+ delete this;

}

// static

« no previous file with comments | « content/shell/android/shell_manager.cc ('k') | no next file » | no next file with comments »