Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3172)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase & ios update Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 15221e5ca2ee3f4dacba7cef01414e99e00c5f1c..857151e7928088458671d472985fb4cf00a8727d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -10,7 +10,6 @@ import android.app.ActivityManager;
import android.app.Dialog;
import android.content.Context;
import android.content.Intent;
-import android.graphics.Bitmap;
import android.graphics.Canvas;
import android.graphics.Color;
import android.graphics.Rect;
@@ -41,7 +40,6 @@ import org.chromium.chrome.browser.favicon.FaviconHelper.IconAvailabilityCallbac
import org.chromium.chrome.browser.favicon.LargeIconBridge;
import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;
import org.chromium.chrome.browser.metrics.StartupMetrics;
-import org.chromium.chrome.browser.ntp.BookmarksPage.BookmarkSelectedListener;
import org.chromium.chrome.browser.ntp.LogoBridge.Logo;
import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
@@ -179,20 +177,6 @@ public class NewTabPage
return url != null && url.startsWith(UrlConstants.NTP_URL);
}
- public static void launchBookmarksDialog(Activity activity, Tab tab,
- TabModelSelector tabModelSelector) {
- if (!EnhancedBookmarkUtils.showEnhancedBookmarkIfEnabled(activity)) {
- BookmarkDialogSelectedListener listener = new BookmarkDialogSelectedListener(tab);
- NativePage page = BookmarksPage.buildPageInDocumentMode(
- activity, tab, tabModelSelector, Profile.getLastUsedProfile(),
- listener);
- page.updateForUrl(UrlConstants.BOOKMARKS_URL);
- Dialog dialog = new NativePageDialog(activity, page);
- listener.setDialog(dialog);
- dialog.show();
- }
- }
-
public static void launchInterestsDialog(Activity activity, final Tab tab) {
InterestsPage page =
new InterestsPage(activity, tab, Profile.getLastUsedProfile());
@@ -388,11 +372,7 @@ public class NewTabPage
public void navigateToBookmarks() {
if (mIsDestroyed) return;
RecordUserAction.record("MobileNTPSwitchToBookmarks");
- if (FeatureUtilities.isDocumentMode(mActivity)) {
- launchBookmarksDialog(mActivity, mTab, mTabModelSelector);
- } else if (!EnhancedBookmarkUtils.showEnhancedBookmarkIfEnabled(mActivity)) {
- mTab.loadUrl(new LoadUrlParams(UrlConstants.BOOKMARKS_URL));
- }
+ EnhancedBookmarkUtils.showBookmarkManager(mActivity);
}
@Override
@@ -779,28 +759,4 @@ public class NewTabPage
public void captureThumbnail(Canvas canvas) {
mNewTabPageView.captureThumbnail(canvas);
}
-
- private static class BookmarkDialogSelectedListener implements BookmarkSelectedListener {
- private Dialog mDialog;
- private final Tab mTab;
-
- public BookmarkDialogSelectedListener(Tab tab) {
- mTab = tab;
- }
-
- @Override
- public void onNewTabOpened() {
- if (mDialog != null) mDialog.dismiss();
- }
-
- @Override
- public void onBookmarkSelected(String url, String title, Bitmap favicon) {
- if (mDialog != null) mDialog.dismiss();
- mTab.loadUrl(new LoadUrlParams(url));
- }
-
- public void setDialog(Dialog dialog) {
- mDialog = dialog;
- }
- }
}

Powered by Google App Engine
This is Rietveld 408576698