chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java - Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase & ios update Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/BookmarksPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

index 4de8afabd0986fd5031ec3d90ee44248aaa2ec24..0c1ddb9a6e1410a121e8f17d8b6d443c4fbcbf5b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

@@ -11,7 +11,6 @@ import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.browser.NativePage;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkPage;

-import org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarkUtils;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

import org.chromium.chrome.browser.util.FeatureUtilities;

@@ -39,10 +38,10 @@ public class NativePageFactory {

protected NativePage buildBookmarksPage(Activity activity, Tab tab,

TabModelSelector tabModelSelector) {

- if (EnhancedBookmarkUtils.isEnhancedBookmarkEnabled()

- && DeviceFormFactor.isTablet(activity)) {

+ if (DeviceFormFactor.isTablet(activity)) {

return EnhancedBookmarkPage.buildPage(activity, tab);

} else {

+ // TODO(kkimlabs): Remove BookmarksPage completely. http://crbug.com/502911

return BookmarksPage.buildPage(activity, tab, tabModelSelector);

}