Issue 14964004: Implement preserveAspectRatio=none for SVG images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14964004: Implement preserveAspectRatio=none for SVG images (Closed)

Created:
7 years, 7 months ago by pdr.

Modified:
7 years, 7 months ago

Reviewers:
Stephen Chennney

CC:
blink-reviews, pdr, Stephen Chennney, f(malita), jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Implement preserveAspectRatio=none for SVG images Previously, preserveAspectRatio=none had no effect on SVG images. This change fixes this so we follow the special handling of preserveAspectRatio on images as defined in the spec: http://www.w3.org/TR/SVG/single-page.html, 7.8 The ‘preserveAspectRatio’ attribute. Images that depend on a container size (such as SVG images) require a call to setContainerSizeForRenderer(...) to set this size. By passing the image's intrinsic size as the container size, the non-uniform scaling defined in the spec will be achieved. BUG=173360 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149936

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -5 lines)			Patch
A	LayoutTests/svg/custom/image-with-preserveAspectRatio-none.html	View	1 chunk	+11 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/custom/image-with-preserveAspectRatio-none-expected.html	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGImage.cpp	View	1 chunk	+21 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/14964004/1

7 years, 7 months ago (2013-05-08 05:40:42 UTC) #3

Message was sent while issue was closed.

Change committed as 149936

Expand Messages | Collapse Messages