Issue 14935015: DevTools: devtools flickers when toggling between tab w/ tools and tab w/o tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14935015: DevTools: devtools flickers when toggling between tab w/ tools and tab w/o tools. (Closed)

Created:
7 years, 7 months ago by pfeldman

Modified:
7 years, 7 months ago

Reviewers:
sail, dhollowa

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DevTools: devtools flickers when toggling between tab w/ tools and tab w/o tools. Follow up to https://codereview.chromium.org/12254021. Currently, Mac has an NSView wrapper around the internal contents' native view. Internal NSView respects the bookmarks bubble and is currently updated upon setTopContentOffset. I swapped frame updates for internal and external NSViews to reduce the flickering as a short term solution. We really need to change it in a way that only one update is taking place. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202458