chrome/browser/ui/cocoa/dev_tools_controller.mm - Issue 14935015: DevTools: devtools flickers when toggling between tab w/ tools and tab w/o tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/dev_tools_controller.mm

Issue 14935015: DevTools: devtools flickers when toggling between tab w/ tools and tab w/o tools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/dev_tools_controller.mm

diff --git a/chrome/browser/ui/cocoa/dev_tools_controller.mm b/chrome/browser/ui/cocoa/dev_tools_controller.mm

index 21a62c1cb5378f9a064dc73d3d29eeb4119770ef..c495d1f9c09efa2ea9335243506b4a710963a442 100644

--- a/chrome/browser/ui/cocoa/dev_tools_controller.mm

+++ b/chrome/browser/ui/cocoa/dev_tools_controller.mm

@@ -163,11 +163,11 @@ using content::WebContents;

[[NSView alloc] initWithFrame:containerRect]);

[devToolsContainerView addSubview:devToolsView];

[splitView_ addSubview:devToolsContainerView];

- [self updateDevToolsViewFrame];

BOOL isVertical = devToolsWindow_->dock_side() == DEVTOOLS_DOCK_SIDE_RIGHT;

[splitView_ setVertical:isVertical];

[self updateDevToolsSplitPosition];

+ [self updateDevToolsViewFrame];

}

- (void)hideDevToolsContainer {

« no previous file with comments | « no previous file | no next file » | no next file with comments »