Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: media/base/android/media_codec_bridge_unittest.cc

Issue 14932020: Add Create() function to AudioCodecBridge and VideoCodecBridge to allow return of null pointers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_codec_bridge_unittest.cc
diff --git a/media/base/android/media_codec_bridge_unittest.cc b/media/base/android/media_codec_bridge_unittest.cc
index acf421e11dbb21ec873349b063f349a92eb31c11..8bf12ecb68090fa18d03f702a78e5772fbce2dc0 100644
--- a/media/base/android/media_codec_bridge_unittest.cc
+++ b/media/base/android/media_codec_bridge_unittest.cc
@@ -97,7 +97,7 @@ TEST(MediaCodecBridgeTest, Initialize) {
return;
scoped_ptr<media::MediaCodecBridge> media_codec;
- media_codec.reset(new VideoCodecBridge(kCodecH264));
+ media_codec.reset(VideoCodecBridge::Create(kCodecH264));
}
TEST(MediaCodecBridgeTest, DoNormal) {
@@ -105,7 +105,7 @@ TEST(MediaCodecBridgeTest, DoNormal) {
return;
scoped_ptr<media::AudioCodecBridge> media_codec;
- media_codec.reset(new AudioCodecBridge(kCodecMP3));
+ media_codec.reset(AudioCodecBridge::Create(kCodecMP3));
media_codec->Start(kCodecMP3, 44100, 2, NULL, 0);
@@ -164,7 +164,7 @@ TEST(MediaCodecBridgeTest, InvalidVorbisHeader) {
return;
scoped_ptr<media::AudioCodecBridge> media_codec;
- media_codec.reset(new AudioCodecBridge(kCodecVorbis));
+ media_codec.reset(AudioCodecBridge::Create(kCodecVorbis));
// The first byte of the header is not 0x02.
uint8 invalid_first_byte[] = { 0x00, 0xff, 0xff, 0xff, 0xff };

Powered by Google App Engine
This is Rietveld 408576698