content/common/gpu/media/android_video_decode_accelerator.cc - Issue 14932020: Add Create() function to AudioCodecBridge and VideoCodecBridge to allow return of null pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/android_video_decode_accelerator.cc

Issue 14932020: Add Create() function to AudioCodecBridge and VideoCodecBridge to allow return of null pointers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/media/android_video_decode_accelerator.cc

diff --git a/content/common/gpu/media/android_video_decode_accelerator.cc b/content/common/gpu/media/android_video_decode_accelerator.cc

index 4d65c61131fac0145e4fdbba3dc9a2d8e120d3b9..3391e54a6810542e2e4175d359680a9f41c92fb2 100644

--- a/content/common/gpu/media/android_video_decode_accelerator.cc

+++ b/content/common/gpu/media/android_video_decode_accelerator.cc

@@ -379,7 +379,7 @@ void AndroidVideoDecodeAccelerator::Flush() {

void AndroidVideoDecodeAccelerator::ConfigureMediaCodec() {

dwkang1 2013/05/16 01:53:54 Could you make this return bool and make Initializ

qinmin 2013/05/16 04:07:43 Done.

DCHECK(surface_texture_.get());

- media_codec_.reset(new media::VideoCodecBridge(codec_));

+ media_codec_.reset(media::VideoCodecBridge::Create(codec_));

gfx::ScopedJavaSurface surface(surface_texture_.get());

// VDA does not pass the container indicated resolution in the initialization

« no previous file with comments | « no previous file | media/base/android/media_codec_bridge.h » ('j') | no next file with comments »