Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: media/base/android/media_codec_bridge.h

Issue 14932020: Add Create() function to AudioCodecBridge and VideoCodecBridge to allow return of null pointers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_codec_bridge.h
diff --git a/media/base/android/media_codec_bridge.h b/media/base/android/media_codec_bridge.h
index b1f779edcc4cb0e02e73c13e1065ed0f9977e081..d1531c6aebc0eaf94ae9ac6c03bef20dc159aa9a 100644
--- a/media/base/android/media_codec_bridge.h
+++ b/media/base/android/media_codec_bridge.h
@@ -114,21 +114,26 @@ class MediaCodecBridge {
class AudioCodecBridge : public MediaCodecBridge {
public:
- explicit AudioCodecBridge(const AudioCodec codec);
+ static AudioCodecBridge* Create(const AudioCodec codec);
// Start the audio codec bridge.
bool Start(const AudioCodec codec, int sample_rate, int channel_count,
const uint8* extra_data, size_t extra_data_size);
+ private:
+ explicit AudioCodecBridge(const char* mime);
};
class VideoCodecBridge : public MediaCodecBridge {
public:
- explicit VideoCodecBridge(const VideoCodec codec);
+ static VideoCodecBridge* Create(const VideoCodec codec);
// Start the video codec bridge.
// TODO(qinmin): Pass codec specific data if available.
bool Start(
const VideoCodec codec, const gfx::Size& size, jobject surface);
+
+ private:
+ explicit VideoCodecBridge(const char* mime);
};
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698