Add Create() function to AudioCodecBridge and VideoCodecBridge to allow return of null pointers

content/common/gpu/media/android_video_decode_accelerator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/media/android_video_decode_accelerator.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "content/common/gpu/gpu_channel.h"
@@ skipping 358 matching lines @@
   if (!io_task_is_posted_)
     DoIOTask();
 }
 
 void AndroidVideoDecodeAccelerator::Flush() {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   Decode(media::BitstreamBuffer(-1, base::SharedMemoryHandle(), 0));
 }
 
 void AndroidVideoDecodeAccelerator::ConfigureMediaCodec() {

[dwkang1, 2013/05/16 01:53:54]

Could you make this return bool and make Initialize() return false when
VideoCodecBridge::Create() returns null?

[qinmin, 2013/05/16 04:07:43]

Done.

   DCHECK(surface_texture_.get());
 
-  media_codec_.reset(new media::VideoCodecBridge(codec_));
+  media_codec_.reset(media::VideoCodecBridge::Create(codec_));
 
   gfx::ScopedJavaSurface surface(surface_texture_.get());
   // VDA does not pass the container indicated resolution in the initialization
   // phase. Here, we set 720p by default.
   // TODO(dwkang): find out a way to remove the following hard-coded value.
   media_codec_->Start(
       codec_, gfx::Size(1280, 720), surface.j_surface().obj());
   media_codec_->GetOutputBuffers();
 }
 
@@ skipping 66 matching lines @@
 void AndroidVideoDecodeAccelerator::NotifyResetDone() {
   client_->NotifyResetDone();
 }
 
 void AndroidVideoDecodeAccelerator::NotifyError(
     media::VideoDecodeAccelerator::Error error) {
   client_->NotifyError(error);
 }
 
 }  // namespace content