Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 14904005: Make Range constructable (Closed)

Created:
7 years, 7 months ago by arv (Not doing code reviews)
Modified:
7 years, 7 months ago
Reviewers:
Julie Parent, eseidel, ojan
CC:
blink-reviews
Visibility:
Public.

Description

Make Range constructable http://dom.spec.whatwg.org/#interface-range Now we can do `new Range()` instead of `document.createRange()`. BUG=237901 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149794

Patch Set 1 #

Patch Set 2 : Add cross frame test #

Patch Set 3 : Update expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -4 lines) Patch
A LayoutTests/fast/dom/Range/range-constructor.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/Range/range-constructor-expected.txt View 1 1 chunk +18 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/dom-constructors.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/dom-constructors-expected.txt View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/dom/Range.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/Range.idl View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
arv (Not doing code reviews)
7 years, 7 months ago (2013-05-03 21:34:52 UTC) #1
Julie Parent
Maybe worth adding a test in a multi-document setting to ensure that the correct document ...
7 years, 7 months ago (2013-05-03 21:50:38 UTC) #2
eseidel
Does HTML5 say this is OK? I like this. But I don't want this to ...
7 years, 7 months ago (2013-05-04 01:20:42 UTC) #3
eseidel
lgtm Sorry, I missed the spec link. So what's the story with other browsers? This ...
7 years, 7 months ago (2013-05-04 01:29:07 UTC) #4
arv (Not doing code reviews)
On 2013/05/04 01:29:07, Eric Seidel (Google) wrote: > lgtm > > Sorry, I missed the ...
7 years, 7 months ago (2013-05-06 14:15:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14904005/11001
7 years, 7 months ago (2013-05-06 20:58:19 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 21:00:42 UTC) #7
Message was sent while issue was closed.
Change committed as 149794

Powered by Google App Engine
This is Rietveld 408576698