Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 1490193003: [Password Manager] Update Confirmation UI for saved password change for Chrome on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/strings/android_chrome_strings.grd
diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
index 78ec2a7df668b30fabd2f3a287c615022c57d6c6..8b43185fa9b98aa81317c685cc5ad8a82b175d68 100644
--- a/chrome/android/java/strings/android_chrome_strings.grd
+++ b/chrome/android/java/strings/android_chrome_strings.grd
@@ -826,7 +826,7 @@ To obtain new licenses, connect to the internet and play your downloaded content
<message name="IDS_ACCOUNT_MANAGEMENT_NOT_YOU_TEXT" desc="Title text for the section with the incognito button.">
Not <ph name="NOT_YOU_USER_NAME">%1$s<ex>Pablo Picasso</ex></ph>?
</message>
-
+
gone 2016/01/26 19:59:22 nit: remove.
melandory 2016/01/29 15:56:14 Done.
<!-- Child accounts -->
<message name="IDS_KIDS_ACCOUNT" desc="Identifies an account as a child account.">
This is a kid’s account
@@ -2384,6 +2384,14 @@ Chrome will scan for nearby pages when your device is unlocked. These pages will
<message name="IDS_PHYSICAL_WEB_REFRESH" desc="The label for a button that initiates a scan for nearby URLs">
Refresh
</message>
+
+ <!-- Password Manager strings -->
gone 2016/01/26 19:59:22 Use the existing IDS_UPDATE_PASSWORD; redefining t
melandory 2016/01/29 15:56:14 My problem here is that if I pass IDS_UPDATE_PASSW
gone 2016/01/29 18:31:24 Huh. TIL Android uses a different placeholder. L
+ <message name="IDS_UPDATE_PASSWORD" desc="The title of the update password infobar.">
+ Do you want <ph name="PASSWORD_MANAGER_BRAND">^1<ex>Google Chrome</ex></ph> to update your password for this site?
+ </message>
+ <message name="IDS_UPDATE_PASSWORD_FOR_ACCOUNT" desc="The title of the update password infobar.">
gone 2016/01/26 19:59:22 Will this string ever be used on non-Android? If
melandory 2016/01/29 15:56:14 Nope, due to difference in the UI, it will never b
gone 2016/01/29 18:31:24 Alright. If it ends up on iOS we can swap it over
+ Do you want <ph name="PASSWORD_MANAGER_BRAND">^1<ex>Google Chrome</ex></ph> to update your password of <ph name="USERNAME">^2<ex>don.john.lemon@example.com</ex></ph> for this site?
+ </message>
</messages>
</release>
</grit>

Powered by Google App Engine
This is Rietveld 408576698