Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 14890021: Remove isIRect "optimization" & defer computation of device Rect in AA rect rendering (Closed)

Created:
7 years, 7 months ago by robertphillips
Modified:
7 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This doesn't seem to make much of a difference either way performance-wise (at least on Windows with a repeat count of 100). These 4 tests survived a pruning of anything <= .5ms and <= 3% and appeared in two consecutive tests (old is on left; new is on right): Test1 blur_10_inner_low_quality GPU c 4.52 5.30 -0.78 -17.3% blur_100.50_normal_low_quality GPU c 8.11 9.05 -0.94 -11.6% arbroundrect GPU c 47.42 45.86 +1.56 +3.3% giantdashline_hori_2 GPU c 42.43 40.25 +2.18 +5.1% Test2: blur_10_outer_low_quality GPU c 4.21 4.84 -0.63 -15.0% blur_100.50_normal_low_quality GPU c 7.96 9.05 -1.09 -13.7% arbroundrect GPU c 48.05 46.49 +1.56 +3.2% giantdashline_hori_2 GPU c 43.37 41.34 +2.03 +4.7%

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -30 lines) Patch
M include/gpu/GrAARectRenderer.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 4 chunks +12 lines, -7 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
7 years, 7 months ago (2013-05-09 20:13:11 UTC) #1
brian1
On 2013/05/09 20:13:11, robertphillips wrote: Lgtm
7 years, 7 months ago (2013-05-10 02:56:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/14890021/1
7 years, 7 months ago (2013-05-10 10:14:56 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildBench, BuildGM, BuildMost, BuildSkiaBaseLibs, BuildTests, BuildTools ...
7 years, 7 months ago (2013-05-10 10:22:37 UTC) #4
robertphillips
7 years, 7 months ago (2013-05-10 11:06:57 UTC) #5
Message was sent while issue was closed.
committed as r9087

Powered by Google App Engine
This is Rietveld 408576698