Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1487883002: Mark precompilation_dart2js_test as slow in debug mode. (Closed)

Created:
5 years ago by rmacnak
Modified:
5 years ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark precompilation_dart2js_test as slow in debug mode. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/289cdf9040b135c35ea02b33cf39cf8d8f1170cc

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tests/standalone/standalone.status View 1 2 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
5 years ago (2015-12-01 19:30:31 UTC) #2
srdjan
lgtm https://chromiumcodereview.appspot.com/1487883002/diff/20001/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://chromiumcodereview.appspot.com/1487883002/diff/20001/tests/standalone/standalone.status#newcode142 tests/standalone/standalone.status:142: [ $arch == simarm || $arch == simarmv5te ...
5 years ago (2015-12-01 19:41:12 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/1487883002/diff/20001/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://chromiumcodereview.appspot.com/1487883002/diff/20001/tests/standalone/standalone.status#newcode142 tests/standalone/standalone.status:142: [ $arch == simarm || $arch == simarmv5te || ...
5 years ago (2015-12-01 20:47:19 UTC) #4
rmacnak
5 years ago (2015-12-01 20:48:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
289cdf9040b135c35ea02b33cf39cf8d8f1170cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698