Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3052)

Unified Diff: build/common.gypi

Issue 14876034: Enable Clang warnings for implementation files on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gypi style tweak Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c61a70ea9b986932d50a2c26696f2e0ccfc7887a..e77aa3191393f55146789c4c7799f5e31dd259c7 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1551,27 +1551,8 @@
'grit_defines': ['-D', 'use_concatenated_impulse_responses'],
}],
['clang_use_chrome_plugins==1 and OS!="win"', {
- 'variables': {
- 'clang_chrome_plugins_flags': [
- '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
- ],
- },
- 'conditions': [
- ['OS=="linux" or OS=="mac"', {
- 'clang_chrome_plugins_flags': [
- '<@(clang_chrome_plugins_flags)'
- ],
- }, {
- # TODO(rsleevi): http://crbug.com/115047 - This warning is only
- # enabled for Linux for now. Disable everywhere else.
- 'clang_chrome_plugins_flags': [
- '<@(clang_chrome_plugins_flags)',
- '-Xclang',
- '-plugin-arg-find-bad-constructs',
- '-Xclang',
- 'skip-virtuals-in-implementations',
- ],
- }]
+ 'clang_chrome_plugins_flags': [
+ '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
],
}],

Powered by Google App Engine
This is Rietveld 408576698