Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 14874005: Use logger formatting instead of string interpolation. (Closed)

Created:
7 years, 7 months ago by Mike Stip (use stip instead)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, Isaac (away)
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Use logger formatting instead of string interpolation. Follow-up to ilevy's comments in https://chromiumcodereview.appspot.com/14759006/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=198236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gclient_utils.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike Stip (use stip instead)
quick fixup, ptal!
7 years, 7 months ago (2013-05-03 22:59:35 UTC) #1
Dirk Pranke
lgtm.
7 years, 7 months ago (2013-05-03 23:21:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/14874005/1
7 years, 7 months ago (2013-05-03 23:22:14 UTC) #3
commit-bot: I haz the power
Change committed as 198236
7 years, 7 months ago (2013-05-03 23:23:53 UTC) #4
Isaac (away)
7 years, 7 months ago (2013-05-04 00:50:09 UTC) #5
Message was sent while issue was closed.
What about my other comments?  Why not wait for my review if you're trying to
address my comments?

Powered by Google App Engine
This is Rietveld 408576698