Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: gclient_utils.py

Issue 14874005: Use logger formatting instead of string interpolation. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_utils.py
diff --git a/gclient_utils.py b/gclient_utils.py
index d0fa201b2addf676059286472c52b9d2a546a0d1..54d4e0ecf5ce374556006a502b0f05a3fd471361 100644
--- a/gclient_utils.py
+++ b/gclient_utils.py
@@ -745,17 +745,17 @@ class ExecutionQueue(object):
try:
self.item.run(*self.args, **self.kwargs)
except KeyboardInterrupt:
- logging.info('Caught KeyboardInterrupt in thread %s' % self.item.name)
+ logging.info('Caught KeyboardInterrupt in thread %s', self.item.name)
logging.info(str(sys.exc_info()))
work_queue.exceptions.put(sys.exc_info())
raise
except Exception:
# Catch exception location.
- logging.info('Caught exception in thread %s' % self.item.name)
+ logging.info('Caught exception in thread %s', self.item.name)
logging.info(str(sys.exc_info()))
work_queue.exceptions.put(sys.exc_info())
finally:
- logging.info('_Worker.run(%s) done' % self.item.name)
+ logging.info('_Worker.run(%s) done', self.item.name)
work_queue.ready_cond.acquire()
try:
work_queue.ready_cond.notifyAll()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698