Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1486543003: Move blimp/net/test_common.h/cc to a separate source_set. (Closed)

Created:
5 years ago by David Trainor- moved to gerrit
Modified:
5 years ago
Reviewers:
Kevin M
CC:
chromium-reviews, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@blimp_tie
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move blimp/net/test_common.h/cc to a separate source_set. - Allow blimp/net/test_common to be used by other packages that might need to create a MockBlimpMessageProcessor without depending on the whole //blimp/net:tests target. BUG=550693 Committed: https://crrev.com/ca0470f5edd02603e45e06d85cbd81f2ab437d91 Cr-Commit-Position: refs/heads/master@{#362765}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fixed component build breaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -45 lines) Patch
M blimp/client/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/compositor/render_widget_message_processor_unittest.cc View 3 chunks +4 lines, -21 lines 0 comments Download
M blimp/engine/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/engine/browser/engine_render_widget_message_processor_unittest.cc View 4 chunks +5 lines, -22 lines 0 comments Download
M blimp/net/BUILD.gn View 1 2 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
David Trainor- moved to gerrit
ptal. I added blimp/net/blimp_net_test_export.h and put the new target just in blimp/net. If you want ...
5 years ago (2015-12-01 00:25:23 UTC) #2
Kevin M
lgtm
5 years ago (2015-12-01 02:14:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486543003/1
5 years ago (2015-12-01 07:05:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/101033) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-01 07:08:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486543003/20001
5 years ago (2015-12-01 16:14:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/148147)
5 years ago (2015-12-01 16:39:37 UTC) #12
David Trainor- moved to gerrit
made the test_support target a source_set, which fixed the build issues.
5 years ago (2015-12-02 18:26:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1486543003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1486543003/40001
5 years ago (2015-12-02 18:36:42 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-02 19:12:53 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-02 19:14:29 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ca0470f5edd02603e45e06d85cbd81f2ab437d91
Cr-Commit-Position: refs/heads/master@{#362765}

Powered by Google App Engine
This is Rietveld 408576698