Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: blimp/net/BUILD.gn

Issue 1486543003: Move blimp/net/test_common.h/cc to a separate source_set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blimp_tie
Patch Set: Fixed component build breaks. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/browser/engine_render_widget_message_processor_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/BUILD.gn
diff --git a/blimp/net/BUILD.gn b/blimp/net/BUILD.gn
index feb3adeec8c15f2ad5a3e90600b3920102aff439..4010a0ba8a364a14e8ec6bdd10348230e8c95fb4 100644
--- a/blimp/net/BUILD.gn
+++ b/blimp/net/BUILD.gn
@@ -56,6 +56,23 @@ component("blimp_net") {
]
}
+source_set("test_support") {
+ testonly = true
+
+ sources = [
+ "blimp_net_test_export.h",
+ "test_common.cc",
+ "test_common.h",
+ ]
+
+ deps = [
+ ":blimp_net",
+ "//blimp/common/proto",
+ "//net:test_support",
+ "//testing/gmock",
+ ]
+}
+
source_set("unit_tests") {
testonly = true
@@ -69,12 +86,11 @@ source_set("unit_tests") {
"stream_packet_reader_unittest.cc",
"stream_packet_writer_unittest.cc",
"tcp_transport_unittest.cc",
- "test_common.cc",
- "test_common.h",
]
deps = [
":blimp_net",
+ ":test_support",
"//base",
"//base/test:run_all_unittests",
"//base/test:test_support",
« no previous file with comments | « blimp/engine/browser/engine_render_widget_message_processor_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698