Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: tests/owners.sh

Issue 14854003: Make git-cl more accurately imitate git's editor selection process, and respect $VISUAL. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Make tests use $GIT_EDITOR instead of $EDITOR (previously they failed for me, as $EDITOR was overriā€¦ Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/git_cl_test.py ('k') | tests/patch.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/owners.sh
diff --git a/tests/owners.sh b/tests/owners.sh
index 4a4fc636240807499824be63ec6ff1f1331f9816..baa7dd9b0ac7b4c76d311f39a6a135f3bd167a96 100755
--- a/tests/owners.sh
+++ b/tests/owners.sh
@@ -16,7 +16,7 @@ setup_gitsvn
set -e
cd git-svn
git config rietveld.server localhost:8080
- export EDITOR=$(which true)
+ export GIT_EDITOR=$(which true)
git checkout -q -b work
echo "ben@chromium.org" > OWNERS
« no previous file with comments | « tests/git_cl_test.py ('k') | tests/patch.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698