Make git-cl more accurately imitate git's editor selection process, and respect $VISUAL.

tests/owners.sh

 #!/bin/bash
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 set -e
 
 . ./test-lib.sh
 
 setup_initsvn
 setup_gitsvn
 
 (
 
   set -e
   cd git-svn
   git config rietveld.server localhost:8080
-  export EDITOR=$(which true)
+  export GIT_EDITOR=$(which true)
 
   git checkout -q -b work
   echo "ben@chromium.org" > OWNERS
   cat <<END > PRESUBMIT.py
 def CheckChangeOnCommit(input_api, output_api):
   return input_api.canned_checks.CheckOwners(input_api, output_api)
 
 CheckChangeOnUpload = CheckChangeOnCommit
 END
 
@@ skipping 11 matching lines @@
   test_expect_success "git-cl dcommit --tbr succeeds" \
     "$GIT_CL dcommit --tbr -f | grep -q -- '--tbr was specified'"
 )
 SUCCESS=$?
 
 cleanup
 
 if [ $SUCCESS == 0 ]; then
   echo PASS
 fi