Turn the load field code stub into a hydrogen code stub.

Turn the load field code stub into a hydrogen code stub.

Committed: https://code.google.com/p/v8/source/detail?r=14526

[Toon Verwaest, 2013-05-02 09:41:57]

PTAL

[danno, 2013-05-02 10:56:59]

https://codereview.chromium.org/14847004/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/14847004/diff/1/src/code-stubs.h#newcode820
src/code-stubs.h:820: class UnboxedDoubleBits: public BitField<bool, 16, 1> {};
Seems premature for this CL?

https://codereview.chromium.org/14847004/diff/1/src/code-stubs.h#newcode830
src/code-stubs.h:830: bool inobject_;
Other stubs store the |'ed version in a field called bit_field_ and extract them
in accessors. Any reason to not do that here?

https://codereview.chromium.org/14847004/diff/1/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):

https://codereview.chromium.org/14847004/diff/1/src/ia32/stub-cache-ia32.cc#n...
src/ia32/stub-cache-ia32.cc:1240: if (!reg.is(receiver())) __ mov(receiver(),
reg);
Seems like you should try to clean this up in a follow-up CL that the receiver
is always in the right register on all platforms. Perhaps a comment would be a
good idea for now to explain why this move is needed (with a TODO).

[danno, 2013-05-02 11:41:48]

https://codereview.chromium.org/14847004/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/14847004/diff/1/src/code-stubs.h#newcode802
src/code-stubs.h:802: if (unboxed_double_) return Representation::Double();
Not yet?

[Toon Verwaest, 2013-05-02 12:02:43]

Addressed comments, PTAL again.

[danno, 2013-05-02 15:32:36]

https://codereview.chromium.org/14847004/diff/7001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/14847004/diff/7001/src/code-stubs.h#newcode769
src/code-stubs.h:769: Code::Kind kind() { return kind_; }
Either make virtual or remove.

[Toon Verwaest, 2013-05-02 16:16:09]

Addressed comments, ptal again

[danno, 2013-05-02 16:29:54]

lgtm if you address comments

https://chromiumcodereview.appspot.com/14847004/diff/15001/src/code-stubs.h
File src/code-stubs.h (right):

https://chromiumcodereview.appspot.com/14847004/diff/15001/src/code-stubs.h#n...
src/code-stubs.h:762: explicit HICStub()
no explicit here, only for single argument constructors.

https://chromiumcodereview.appspot.com/14847004/diff/15001/src/code-stubs.h#n...
src/code-stubs.h:787: explicit LoadFieldStub() : HandlerStub() { }
no explicit here either, there are no arguments. Also, please make this
protected.

[Toon Verwaest, 2013-05-02 16:32:58]

Committed patchset #4 manually as r14526 (presubmit successful).