Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 14847004: Turn the load field code stub into a hydrogen code stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1178 matching lines...) Expand 10 before | Expand all | Expand 10 after
1189 if (!global.is_null()) { 1189 if (!global.is_null()) {
1190 GenerateCheckPropertyCell(masm(), global, name, scratch2(), &miss); 1190 GenerateCheckPropertyCell(masm(), global, name, scratch2(), &miss);
1191 } 1191 }
1192 1192
1193 HandlerFrontendFooter(success, &miss); 1193 HandlerFrontendFooter(success, &miss);
1194 } 1194 }
1195 1195
1196 1196
1197 void BaseLoadStubCompiler::GenerateLoadField(Register reg, 1197 void BaseLoadStubCompiler::GenerateLoadField(Register reg,
1198 Handle<JSObject> holder, 1198 Handle<JSObject> holder,
1199 PropertyIndex index) { 1199 PropertyIndex field) {
1200 // Get the value from the properties. 1200 if (!reg.is(receiver())) __ movq(receiver(), reg);
1201 GenerateFastPropertyLoad(masm(), rax, reg, holder, index); 1201 if (kind() == Code::LOAD_IC) {
1202 __ ret(0); 1202 LoadFieldStub stub(field.is_inobject(holder),
1203 field.translate(holder));
1204 GenerateTailCall(masm(), stub.GetCode(isolate()));
1205 } else {
1206 KeyedLoadFieldStub stub(field.is_inobject(holder),
1207 field.translate(holder));
1208 GenerateTailCall(masm(), stub.GetCode(isolate()));
1209 }
1203 } 1210 }
1204 1211
1205 1212
1206 void BaseLoadStubCompiler::GenerateLoadCallback( 1213 void BaseLoadStubCompiler::GenerateLoadCallback(
1207 Register reg, 1214 Register reg,
1208 Handle<ExecutableAccessorInfo> callback) { 1215 Handle<ExecutableAccessorInfo> callback) {
1209 // Insert additional parameters into the stack frame above return address. 1216 // Insert additional parameters into the stack frame above return address.
1210 ASSERT(!scratch2().is(reg)); 1217 ASSERT(!scratch2().is(reg));
1211 __ pop(scratch2()); // Get return address to place it below. 1218 __ pop(scratch2()); // Get return address to place it below.
1212 1219
(...skipping 2310 matching lines...) Expand 10 before | Expand all | Expand 10 after
3523 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3530 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3524 } 3531 }
3525 } 3532 }
3526 3533
3527 3534
3528 #undef __ 3535 #undef __
3529 3536
3530 } } // namespace v8::internal 3537 } } // namespace v8::internal
3531 3538
3532 #endif // V8_TARGET_ARCH_X64 3539 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698