Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 14842016: Volume click should be marked as default handled

Created:
7 years, 7 months ago by calvaris
Modified:
7 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews, feature-media-reviews_chromium.org, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Volume click should be marked as default handled BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/html/shadow/MediaControlElementTypes.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
No reviewers yet.
7 years, 7 months ago (2013-05-13 10:43:46 UTC) #1
eseidel
can we test this?
7 years, 7 months ago (2013-05-17 08:10:13 UTC) #2
calvaris
On 2013/05/17 08:10:13, eseidel wrote: > can we test this? This comes from https://bugs.webkit.org/show_bug.cgi?id=112548 . ...
7 years, 7 months ago (2013-05-17 09:55:29 UTC) #3
vcarbune.chromium
I think Eric meant to ask if you can add a test to ensure the ...
7 years, 7 months ago (2013-05-17 10:16:56 UTC) #4
calvaris
7 years, 7 months ago (2013-05-17 10:41:57 UTC) #5
On 2013/05/17 10:16:56, vcarbune.chromium wrote:
> I think Eric meant to ask if you can add a test to ensure the behavior
> happens, not necessarily to illustrate an existing bug.
> 
> Maybe you can achieve this through a layout test inspecting the value
> of event.defaultPrevented?

I remember when I was writing the test for WK, that I couldn't find any suitable
check as the event is not defaultPrevented, but default handled and there is no
js binding for that.

Powered by Google App Engine
This is Rietveld 408576698