Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 14827004: cros: Arrow key traversal in views. (Closed)

Created:
7 years, 7 months ago by xiyuan
Modified:
7 years, 5 months ago
Reviewers:
msw, dmazzoni, zel, sky
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, penghuang+watch_chromium.org, dcheng, nona+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

cros: Arrow key traversal in views. - Add arrow key traversal to FocusManager; The behavior is default to off; - Make NativeTextfieldViews::HandleKeyEvent sets |cursor_changed| flag only when cursor position changes for left/right arrow key; This allows left on most left cursor position and right on the most right position to traverse away from the Textfield; - Login screen to turn on the behavior when kiosk oem manifest asks for it and turn if off when the login screen goes away; BUG=236997, 237550 TBR=zelidrag@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198064

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -39 lines) Patch
M chrome/browser/chromeos/login/login_display_host_impl.cc View 5 chunks +46 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/network_dropdown.js View 5 chunks +12 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 1 chunk +4 lines, -2 lines 1 comment Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 4 chunks +35 lines, -2 lines 0 comments Download
M ui/views/focus/focus_manager.h View 3 chunks +19 lines, -1 line 0 comments Download
M ui/views/focus/focus_manager.cc View 4 chunks +22 lines, -0 lines 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
Split from https://codereview.chromium.org/14751010/ as CQ seems not like it.
7 years, 7 months ago (2013-05-02 21:56:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/14827004/1
7 years, 7 months ago (2013-05-02 21:58:05 UTC) #2
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 7 months ago (2013-05-02 22:47:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/14827004/1
7 years, 7 months ago (2013-05-03 01:05:42 UTC) #4
commit-bot: I haz the power
Change committed as 198064
7 years, 7 months ago (2013-05-03 04:56:34 UTC) #5
msw
7 years, 5 months ago (2013-07-25 00:32:53 UTC) #6
Message was sent while issue was closed.
Please see http://crbug.com/264054

https://chromiumcodereview.appspot.com/14827004/diff/1/ui/views/controls/text...
File ui/views/controls/textfield/native_textfield_views.cc (right):

https://chromiumcodereview.appspot.com/14827004/diff/1/ui/views/controls/text...
ui/views/controls/textfield/native_textfield_views.cc:1193: cursor_changed =
model_->GetCursorPosition() != cursor_position;
This is wrong and caused a regression, see http://crbug.com/264054
The cursor position may not change, while the selection range does.

Powered by Google App Engine
This is Rietveld 408576698