cros: Arrow key traversal in views.

chrome/browser/chromeos/login/webui_login_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/webui_login_view.h"
 
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 90 matching lines @@
     gfx::Size preferred_size = child->GetPreferredSize();
     child->SetBounds(width() - preferred_size.width(),
                      0, preferred_size.width(), preferred_size.height());
   }
 }
 
 void RightAlignedView::ChildPreferredSizeChanged(View* child) {
   Layout();
 }
 
+// A class to change arrow key traversal behavior when it's alive.
+class ScopedArrowKeyTraversal {
+ public:
+  explicit ScopedArrowKeyTraversal(bool new_arrow_key_tranversal_enabled)
+      : previous_arrow_key_traversal_enabled_(
+            views::FocusManager::arrow_key_traversal_enabled()) {
+    views::FocusManager::set_arrow_key_traversal_enabled(
+        new_arrow_key_tranversal_enabled);
+  }
+  ~ScopedArrowKeyTraversal() {
+    views::FocusManager::set_arrow_key_traversal_enabled(
+        previous_arrow_key_traversal_enabled_);
+  }
+
+ private:
+  const bool previous_arrow_key_traversal_enabled_;
+  DISALLOW_COPY_AND_ASSIGN(ScopedArrowKeyTraversal);
+};
+
 }  // namespace
 
 namespace chromeos {
 
 // static
 const char WebUILoginView::kViewClassName[] =
     "browser/chromeos/login/WebUILoginView";
 
 // WebUILoginView public: ------------------------------------------------------
 
@@ skipping 200 matching lines @@
 #ifndef NDEBUG
   return false;
 #else
   return true;
 #endif
 }
 
 void WebUILoginView::HandleKeyboardEvent(content::WebContents* source,
                                          const NativeWebKeyboardEvent& event) {
   if (forward_keyboard_event_) {
+    // Disable arrow key traversal because arrow keys are handled via
+    // accelerator when this view has focus.
+    ScopedArrowKeyTraversal arrow_key_traversal(false);
+
     unhandled_keyboard_event_handler_.HandleKeyboardEvent(event,
                                                           GetFocusManager());
   }
 
   // Make sure error bubble is cleared on keyboard event. This is needed
   // when the focus is inside an iframe. Only clear on KeyDown to prevent hiding
   // an immediate authentication error (See crbug.com/103643).
   if (event.type == WebKit::WebInputEvent::KeyDown) {
     content::WebUI* web_ui = GetWebUI();
     if (web_ui)
@@ skipping 48 matching lines @@
   aura::Env::GetInstance()->set_render_white_bg(true);
 }
 
 void WebUILoginView::ReturnFocus(bool reverse) {
   // Return the focus to the web contents.
   webui_login_->web_contents()->FocusThroughTabTraversal(reverse);
   GetWidget()->Activate();
 }
 
 }  // namespace chromeos