third_party/upload.py - Issue 14820015: Images are binaries too, yo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/upload.py

Issue 14820015: Images are binaries too, yo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/upload.py

diff --git a/third_party/upload.py b/third_party/upload.py

index c7899c70a93dbe87f48f20286434e1910e2d773a..14da022c3b633e2fb3360ab6084c03e63ae11281 100755

--- a/third_party/upload.py

+++ b/third_party/upload.py

@@ -1385,8 +1385,8 @@ class GitVCS(VersionControlSystem):

else:

status = "M"

- is_binary = self.IsBinaryData(base_content)

is_image = self.IsImage(filename)

+ is_binary = self.IsBinaryData(base_content) or is_image

cbiesinger 2013/05/08 04:54:15 I'm sort of confused by this code, base_content is

# Grab the before/after content if we need it.

# Grab the base content if we don't have it already.

« no previous file with comments | « no previous file | no next file » | no next file with comments »