Images are binaries too, yo.

third_party/upload.py

 #!/usr/bin/env python
 # coding: utf-8
 #
 # Copyright 2007 Google Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
@@ skipping 1367 matching lines @@
         base_content = RunShell(
             ["git", "show", "HEAD:" + filename], silent_ok=True)
     elif not hash_before:
       status = "A"
       base_content = ""
     elif not hash_after:
       status = "D"
     else:
       status = "M"
 
-    is_binary = self.IsBinaryData(base_content)
     is_image = self.IsImage(filename)
+    is_binary = self.IsBinaryData(base_content) or is_image

[cbiesinger, 2013/05/08 04:54:15]

I'm sort of confused by this code, base_content is not initialized here in most
cases, right? It is initialized below, but it needs to know the value of
is_binary. How is this expected to work?

 
     # Grab the before/after content if we need it.
     # Grab the base content if we don't have it already.
     if base_content is None and hash_before:
       base_content = self.GetFileContent(hash_before, is_binary)
     # Only include the "after" file if it's an image; otherwise it
     # it is reconstructed from the diff.
     if is_image and hash_after:
       new_content = self.GetFileContent(hash_after, is_binary)
 
@@ skipping 984 matching lines @@
     os.environ['LC_ALL'] = 'C'
     RealMain(sys.argv)
   except KeyboardInterrupt:
     print
     StatusUpdate("Interrupted.")
     sys.exit(1)
 
 
 if __name__ == "__main__":
   main()