Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(70)

Issue 14820003: Fix GCC 4.7 warnings about always_inline (Closed)

Created:
6 years, 6 months ago by digit1
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://src.chromium.org/chrome/trunk/deps/third_party/libvpx/
Visibility:
Public.

Description

Fix GCC 4.7 warnings about always_inline The 'always_inline' GCC attribute doesn't imply 'inline'. Recent versions of GCC 4.6+ will dump the following warning when building libvpx due to this: warning: always_inline function might not be inlinable [-Wattributes] This patch fixes the definition of INLINE to get rid of the warnings and ensure the functions are effectively always inlined. See http://gcc.gnu.org/onlinedocs/gcc/Inline.html BUG=NONE

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M source/config/linux/arm-neon-cpu-detect/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/arm-neon/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/arm/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/ia32/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/mipsel/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/x64/vpx_config.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
digit1
6 years, 6 months ago (2013-05-02 19:12:18 UTC) #1
digit1
For the record, this was discovered by updating the NDK binaries used for the Chromium/Android ...
6 years, 6 months ago (2013-05-02 19:13:36 UTC) #2
wwcv
LGTM. Fix upstream to prevent this from happening again: https://gerrit.chromium.org/gerrit/49928 +hclam for a functional LGTM
6 years, 6 months ago (2013-05-02 19:35:58 UTC) #3
Alpha Left Google
LGTM.
6 years, 6 months ago (2013-05-02 20:10:16 UTC) #4
wwcv
6 years, 5 months ago (2013-06-17 18:47:36 UTC) #5
Upstream fix is live.

Configure script updated to generate the correct line:
https://src.chromium.org/viewvc/chrome/trunk/deps/third_party/libvpx/source/l...

Confirmation that correct lines are generated:
https://src.chromium.org/viewvc/chrome/trunk/deps/third_party/libvpx/source/c...

Powered by Google App Engine
This is Rietveld 408576698