Issue 14820003: Fix GCC 4.7 warnings about always_inline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14820003: Fix GCC 4.7 warnings about always_inline (Closed)

Created:
7 years, 7 months ago by digit1

Modified:
6 years, 9 months ago

Reviewers:
wwcv, Johann, Alpha Left Google

CC:
chromium-reviews

Base URL:
https://src.chromium.org/chrome/trunk/deps/third_party/libvpx/

Visibility:
Public.

More Reviews

Description

Fix GCC 4.7 warnings about always_inline The 'always_inline' GCC attribute doesn't imply 'inline'. Recent versions of GCC 4.6+ will dump the following warning when building libvpx due to this: warning: always_inline function might not be inlinable [-Wattributes] This patch fixes the definition of INLINE to get rid of the warnings and ensure the functions are effectively always inlined. See http://gcc.gnu.org/onlinedocs/gcc/Inline.html BUG=NONE

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	source/config/linux/arm-neon-cpu-detect/vpx_config.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/config/linux/arm-neon/vpx_config.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/config/linux/arm/vpx_config.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/config/linux/ia32/vpx_config.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/config/linux/mipsel/vpx_config.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/config/linux/x64/vpx_config.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

digit1

For the record, this was discovered by updating the NDK binaries used for the Chromium/Android ...

7 years, 7 months ago (2013-05-02 19:13:36 UTC) #2

wwcv

LGTM. Fix upstream to prevent this from happening again: https://gerrit.chromium.org/gerrit/49928 +hclam for a functional LGTM

7 years, 7 months ago (2013-05-02 19:35:58 UTC) #3

wwcv

7 years, 6 months ago (2013-06-17 18:47:36 UTC) #5

Upstream fix is live.

Configure script updated to generate the correct line:
https://src.chromium.org/viewvc/chrome/trunk/deps/third_party/libvpx/source/l...

Confirmation that correct lines are generated:
https://src.chromium.org/viewvc/chrome/trunk/deps/third_party/libvpx/source/c...

Expand Messages | Collapse Messages