Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 14798008: Translate: add UMA to measure duration time of infobar user action (Closed)

Created:
7 years, 7 months ago by Takashi Toyoshima
Modified:
7 years, 7 months ago
Reviewers:
MAD
CC:
chromium-reviews
Visibility:
Public.

Description

Translate: add UMA to measure duration time of infobar user action BUG=179277 TEST=unit_tests --gtest_filter='TranslateHelperMetricsTest.*' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200714

Patch Set 1 #

Total comments: 2

Patch Set 2 : (rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M chrome/renderer/translate/translate_helper.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/translate/translate_helper.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/renderer/translate/translate_helper_metrics.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/renderer/translate/translate_helper_metrics.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/translate/translate_helper_metrics_unittest.cc View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Takashi Toyoshima
Hi mad, I'd like to add one more UMA to know how quickly users can ...
7 years, 7 months ago (2013-05-14 12:12:28 UTC) #1
Takashi Toyoshima
Hi mad, I'm afraid of you missing this CL :)
7 years, 7 months ago (2013-05-16 04:07:06 UTC) #2
MAD
Sorry about the delay, was busy with Google I/O extended... LGTM... With one small request. ...
7 years, 7 months ago (2013-05-16 15:09:15 UTC) #3
Takashi Toyoshima
https://chromiumcodereview.appspot.com/14798008/diff/1/chrome/renderer/translate/translate_helper_metrics.cc File chrome/renderer/translate/translate_helper_metrics.cc (right): https://chromiumcodereview.appspot.com/14798008/diff/1/chrome/renderer/translate/translate_helper_metrics.cc#newcode43 chrome/renderer/translate/translate_helper_metrics.cc:43: Done by another CL which is already landed :)
7 years, 7 months ago (2013-05-16 16:46:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/14798008/10001
7 years, 7 months ago (2013-05-16 16:47:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=115121
7 years, 7 months ago (2013-05-16 17:34:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/14798008/10001
7 years, 7 months ago (2013-05-16 19:43:10 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 03:44:51 UTC) #8
Message was sent while issue was closed.
Change committed as 200714

Powered by Google App Engine
This is Rietveld 408576698