Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 14780006: Remove _Unwind_* stubs from pnacl_abi.bc (Closed)

Created:
7 years, 7 months ago by eliben
Modified:
7 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Remove _Unwind_* stubs from pnacl_abi.bc For stable builds, they are provided by unwind_stubs.bc Also, when doing the final bitcode link, gold accepts flags that tell it to allow these symbols to remain undefined, which makes the unstable-with-exceptions builds work. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3339 R=jvoung@chromium.org, mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=11315

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review #

Total comments: 4

Patch Set 3 : Fix according to Mark's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -32 lines) Patch
M pnacl/driver/pnacl-ld.py View 1 2 1 chunk +23 lines, -4 lines 0 comments Download
M pnacl/support/bitcode/pnacl_abi.c View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
eliben
7 years, 7 months ago (2013-05-07 18:04:02 UTC) #1
jvoung (off chromium)
https://codereview.chromium.org/14780006/diff/1/pnacl/driver/pnacl-ld.py File pnacl/driver/pnacl-ld.py (right): https://codereview.chromium.org/14780006/diff/1/pnacl/driver/pnacl-ld.py#newcode105 pnacl/driver/pnacl-ld.py:105: '--undef-sym-check --allow-unresolved=_Unwind_DeleteException ' + keep one exception per line ...
7 years, 7 months ago (2013-05-07 18:11:54 UTC) #2
Mark Seaborn
https://codereview.chromium.org/14780006/diff/1/pnacl/driver/pnacl-ld.py File pnacl/driver/pnacl-ld.py (right): https://codereview.chromium.org/14780006/diff/1/pnacl/driver/pnacl-ld.py#newcode105 pnacl/driver/pnacl-ld.py:105: '--undef-sym-check --allow-unresolved=_Unwind_DeleteException ' + On 2013/05/07 18:11:55, jvoung (cr) ...
7 years, 7 months ago (2013-05-07 18:16:06 UTC) #3
eliben
PTAL https://codereview.chromium.org/14780006/diff/1/pnacl/driver/pnacl-ld.py File pnacl/driver/pnacl-ld.py (right): https://codereview.chromium.org/14780006/diff/1/pnacl/driver/pnacl-ld.py#newcode105 pnacl/driver/pnacl-ld.py:105: '--undef-sym-check --allow-unresolved=_Unwind_DeleteException ' + On 2013/05/07 18:11:55, jvoung ...
7 years, 7 months ago (2013-05-07 18:55:04 UTC) #4
Mark Seaborn
https://codereview.chromium.org/14780006/diff/9001/pnacl/driver/pnacl-ld.py File pnacl/driver/pnacl-ld.py (right): https://codereview.chromium.org/14780006/diff/9001/pnacl/driver/pnacl-ld.py#newcode105 pnacl/driver/pnacl-ld.py:105: '{ALLOW_CXX_EXCEPTIONS ? ' Does there need to be a ...
7 years, 7 months ago (2013-05-07 19:59:05 UTC) #5
eliben
https://codereview.chromium.org/14780006/diff/9001/pnacl/driver/pnacl-ld.py File pnacl/driver/pnacl-ld.py (right): https://codereview.chromium.org/14780006/diff/9001/pnacl/driver/pnacl-ld.py#newcode105 pnacl/driver/pnacl-ld.py:105: '{ALLOW_CXX_EXCEPTIONS ? ' On 2013/05/07 19:59:05, Mark Seaborn wrote: ...
7 years, 7 months ago (2013-05-07 21:03:14 UTC) #6
eliben
PTAL
7 years, 7 months ago (2013-05-07 23:09:13 UTC) #7
jvoung (off chromium)
lgtm
7 years, 7 months ago (2013-05-07 23:12:09 UTC) #8
Mark Seaborn
LGTM
7 years, 7 months ago (2013-05-08 02:33:18 UTC) #9
eliben
7 years, 7 months ago (2013-05-08 15:23:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r11315 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698