Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1911)

Unified Diff: chrome/browser/extensions/activity_log/activity_actions.cc

Issue 14774012: Replaced enum strings with ints in Activity Log database (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added missing Singleton dep Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_actions.cc
diff --git a/chrome/browser/extensions/activity_log/activity_actions.cc b/chrome/browser/extensions/activity_log/activity_actions.cc
index bd3e9e5c27955f839df9052aaa98a85e4616163a..b6195afed74e29cfce84d600ee544cac471c353c 100644
--- a/chrome/browser/extensions/activity_log/activity_actions.cc
+++ b/chrome/browser/extensions/activity_log/activity_actions.cc
@@ -22,13 +22,15 @@ Action::Action(const std::string& extension_id,
bool Action::InitializeTableInternal(sql::Connection* db,
const char* table_name,
const char* content_fields[],
+ const char* field_types[],
const int num_content_fields) {
if (!db->DoesTableExist(table_name)) {
std::string table_creator = base::StringPrintf(
"CREATE TABLE %s (%s", table_name, kTableBasicFields);
for (int i = 0; i < num_content_fields; i++) {
- table_creator += base::StringPrintf(", %s LONGVARCHAR",
- content_fields[i]);
+ table_creator += base::StringPrintf(", %s %s",
+ content_fields[i],
+ field_types[i]);
}
table_creator += ")";
if (!db->Execute(table_creator.c_str()))
@@ -39,9 +41,10 @@ bool Action::InitializeTableInternal(sql::Connection* db,
for (int i = 0; i < num_content_fields; i++) {
if (!db->DoesColumnExist(table_name, content_fields[i])) {
std::string table_updater = base::StringPrintf(
- "ALTER TABLE %s ADD COLUMN %s LONGVARCHAR; ",
+ "ALTER TABLE %s ADD COLUMN %s %s; ",
table_name,
- content_fields[i]);
+ content_fields[i],
+ field_types[i]);
if (!db->Execute(table_updater.c_str()))
return false;
}

Powered by Google App Engine
This is Rietveld 408576698