Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Unified Diff: chrome/browser/extensions/activity_log/activity_actions.h

Issue 14774012: Replaced enum strings with ints in Activity Log database (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added missing Singleton dep Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_actions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/activity_log/activity_actions.h
diff --git a/chrome/browser/extensions/activity_log/activity_actions.h b/chrome/browser/extensions/activity_log/activity_actions.h
index 65a4d13ea6a3ede698bc0f83b0e99334ec52a04a..da7c49990ec62bc59016ae682cb78a25dee32151 100644
--- a/chrome/browser/extensions/activity_log/activity_actions.h
+++ b/chrome/browser/extensions/activity_log/activity_actions.h
@@ -38,9 +38,14 @@ class Action : public base::RefCountedThreadSafe<Action> {
virtual ~Action() {}
// Initialize the table for a given action type.
+ // The content_fields array should list the names of all of the columns in
+ // the database. The field_types should specify the types of the corresponding
+ // columns (e.g., INTEGER or LONGVARCHAR). There should be the same number of
+ // field_types as content_fields, since the two arrays should correspond.
static bool InitializeTableInternal(sql::Connection* db,
const char* table_name,
const char* content_fields[],
+ const char* field_types[],
const int num_content_fields);
private:
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_actions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698