Consolidate functions for updating state after a security origin change.

Consolidate functions for updating state after a security origin change.

Since changing a security origin has security implications, it's better
to consolidate all the functions that update state after a security
origin change into one place.

Also revert to being consistent when these functions are called: only
call them after the security origin actually changes in a call to
Document::setSecurityOrigin().

BUG=none

Committed: https://crrev.com/eaad6362fae91ce9fe55050711d95e52ac21a92a
Cr-Commit-Position: refs/heads/master@{#362019}

[dcheng, 2015-11-26 21:16:27]

Description was changed from

==========
Consolidate functions for updating state after a security origin change.

Also revert to being consistent when these functions are called: only
call them after the security origin actually changes in a call to
Document::setSecurityOrigin().

BUG=none
==========

to

==========
Consolidate functions for updating state after a security origin change.


Since changing a security origin has security implications, it's better
to consolidate all the functions that update state after a security
origin change into one place.

Also revert to being consistent when these functions are called: only
call them after the security origin actually changes in a call to
Document::setSecurityOrigin().

BUG=none
==========

[dcheng, 2015-11-26 21:16:28]

dcheng@chromium.org changed reviewers:
+ alexclarke@chromium.org, haraken@chromium.org

[dcheng, 2015-11-26 21:16:30]

https://codereview.chromium.org/1476953004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/FrameLoader.cpp (left):

https://codereview.chromium.org/1476953004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/FrameLoader.cpp:1071:
m_frame->updateFrameSecurityOrigin();
In this case, the frame scheduler update has no security implications, but
someone browsing the code doesn't necessarily know that. A reader won't
understand why updateFrameSecurityOrigin() is called but
ScriptController::updateSecurityOrigin() is not.

As it turns out, ScriptContext's contract is that didUpdateSecurityOrigin() will
be called after a security origin change, so we should just stick to that
instead of adding an explicit call here.

[dcheng, 2015-11-26 21:16:35]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-26 21:16:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476953004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476953004/1

[commit-bot: I haz the power, 2015-11-26 23:08:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 23:08:54]

Dry run: This issue passed the CQ dry run.

[haraken, 2015-11-26 23:27:02]

LGTM

[Sami, 2015-11-27 11:11:05]

skyostil@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2015-11-27 11:11:06]

lgtm, thanks for the cleanup.

[alex clarke (OOO till 29th), 2015-11-27 12:17:26]

lgtm

[dcheng, 2015-11-27 17:26:34]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-11-27 17:26:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476953004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476953004/1

[commit-bot: I haz the power, 2015-11-27 17:31:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-27 17:32:17]

Description was changed from

==========
Consolidate functions for updating state after a security origin change.


Since changing a security origin has security implications, it's better
to consolidate all the functions that update state after a security
origin change into one place.

Also revert to being consistent when these functions are called: only
call them after the security origin actually changes in a call to
Document::setSecurityOrigin().

BUG=none
==========

to

==========
Consolidate functions for updating state after a security origin change.

Since changing a security origin has security implications, it's better
to consolidate all the functions that update state after a security
origin change into one place.

Also revert to being consistent when these functions are called: only
call them after the security origin actually changes in a call to
Document::setSecurityOrigin().

BUG=none

Committed: https://crrev.com/eaad6362fae91ce9fe55050711d95e52ac21a92a
Cr-Commit-Position: refs/heads/master@{#362019}
==========

[commit-bot: I haz the power, 2015-11-27 17:32:17]

Patchset 1 (id:??) landed as
https://crrev.com/eaad6362fae91ce9fe55050711d95e52ac21a92a
Cr-Commit-Position: refs/heads/master@{#362019}