Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 14763003: HashTraits<RefPtr<P> >::PeekType should be raw pointer for better performance (Closed)

Created:
7 years, 7 months ago by Mikhail
Modified:
7 years, 7 months ago
CC:
blink-reviews, shans, apavlov+blink_chromium.org, pdr, Steve Block, caseq+blink_chromium.org, aandrey+blink_chromium.org, aboxhall, yurys+blink_chromium.org, abarth-chromium, dstockwell, gavinp+loader_chromium.org, jchaffraix+rendering, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, dmazzoni, darktears, Nate Chapin, feature-media-reviews_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, f(malita), Stephen Chennney, jeez, Chris Evans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

HashTraits<RefPtr<P> >::PeekType should be raw pointer for better performance HashTraits<RefPtr<P> >::PeekType should be raw pointer so that we can obviate multiple RefPtr copying when invoking HashMap::get() method (and when HashMap value type is RefPtr). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M Source/core/accessibility/AXObjectCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXObjectCache.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSImageGeneratorValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/InspectorCSSOMWrappers.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/ContentDistributor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/archive/ArchiveResourceCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/animation/CompositeAnimation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderCounter.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/mediasource/MediaSourceRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/HashTraits.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mikhail
Hi, here is the patch improving WTF::HashMap::get() method performance in case HashMap value type is ...
7 years, 7 months ago (2013-05-06 14:21:06 UTC) #1
esprehn
LGTM. You're going to need an LGTM from eseidel or abarth to cover all these ...
7 years, 7 months ago (2013-05-06 16:32:54 UTC) #2
esprehn
In the future you can use Publish+Mail Comments to send a patch for review. Right ...
7 years, 7 months ago (2013-05-06 16:33:27 UTC) #3
eseidel
lgtm
7 years, 7 months ago (2013-05-06 18:43:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/14763003/1
7 years, 7 months ago (2013-05-06 18:44:35 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 19:21:18 UTC) #6
Message was sent while issue was closed.
Change committed as 149773

Powered by Google App Engine
This is Rietveld 408576698