Add Python templating engine Jinja2 to third_party

Add Python templating engine Jinja2 to third_party

A templating engine will make it easier to create/maintain the python code generators in Blink (e.g. https://codereview.chromium.org/14905002/)

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199186

[eseidel, 2013-05-08 08:44:54]

lgtm, but I believe you'll need someone with more owner powers than I.

[darin (slow to review), 2013-05-08 17:51:28]

So the blink repository is going to depend on the chromium repository to get
access to this python library?  Maybe this should be checked into blink's
repository instead?

[abarth-chromium, 2013-05-08 20:00:04]

On 2013/05/08 17:51:28, darin wrote:
> So the blink repository is going to depend on the chromium repository to get
> access to this python library?

We already depend on a bunch of libraries in third_party.  For example, libpng
and libwebp.

> Maybe this should be checked into blink's
> repository instead?

Currently Blink doesn't have any third_party code checked into it.  It gets all
it's third-party code from the Chromium repo.

[darin (slow to review), 2013-05-08 20:21:17]

And you feel like this doesn't create pain when you go to update third
party libraries?  Maybe we rarely ever experience API changes?
On May 8, 2013 1:00 PM, <abarth@chromium.org> wrote:

> On 2013/05/08 17:51:28, darin wrote:
>
>> So the blink repository is going to depend on the chromium repository to
>> get
>> access to this python library?
>>
>
> We already depend on a bunch of libraries in third_party.  For example,
> libpng
> and libwebp.
>
>  Maybe this should be checked into blink's
>> repository instead?
>>
>
> Currently Blink doesn't have any third_party code checked into it.  It
> gets all
> it's third-party code from the Chromium repo.
>
>
https://codereview.chromium.**org/14761007/<https://codereview.chromium.org/1...
>

[darin1, 2013-05-08 20:22:17]

LGTM... just wanted to point out the potential for future pain.
On May 8, 2013 1:21 PM, "Darin Fisher" <darin@chromium.org> wrote:

> And you feel like this doesn't create pain when you go to update third
> party libraries?  Maybe we rarely ever experience API changes?
> On May 8, 2013 1:00 PM, <abarth@chromium.org> wrote:
>
>> On 2013/05/08 17:51:28, darin wrote:
>>
>>> So the blink repository is going to depend on the chromium repository to
>>> get
>>> access to this python library?
>>>
>>
>> We already depend on a bunch of libraries in third_party.  For example,
>> libpng
>> and libwebp.
>>
>>  Maybe this should be checked into blink's
>>> repository instead?
>>>
>>
>> Currently Blink doesn't have any third_party code checked into it.  It
>> gets all
>> it's third-party code from the Chromium repo.
>>
>>
https://codereview.chromium.**org/14761007/<https://codereview.chromium.org/1...
>>
>

[commit-bot: I haz the power, 2013-05-09 01:24:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/14761007/1

[commit-bot: I haz the power, 2013-05-09 01:36:45]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Timothy Loh, 2013-05-09 01:44:05]

I think you used the wrong account for this message.

About future pain in updating the library -- jinja2 is mostly feature complete
and pretty stable, so we probably won't even need to update the library.

On 2013/05/08 20:22:17, darin1 wrote:
> LGTM... just wanted to point out the potential for future pain.

[darin (slow to review), 2013-05-09 03:22:37]

LGTM

OK, it is normal btw for top-level modules in chromium to have their own
third_party directories.  See base/third_party for instance.
On May 8, 2013 6:44 PM, <timloh@chromium.org> wrote:

> I think you used the wrong account for this message.
>
> About future pain in updating the library -- jinja2 is mostly feature
> complete
> and pretty stable, so we probably won't even need to update the library.
>
> On 2013/05/08 20:22:17, darin1 wrote:
>
>> LGTM... just wanted to point out the potential for future pain.
>>
>
>
https://codereview.chromium.**org/14761007/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-05-09 03:33:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timloh@chromium.org/14761007/1

[commit-bot: I haz the power, 2013-05-09 11:33:49]

Change committed as 199186