callTheAdoptionAgency should work asynchronously

callTheAdoptionAgency should work asynchronously

Rather than manipulating the DOM tree directly,
HTMLTreeBuilder::callTheAdoptionAgency should indirect its modifications
through the HTMLConstructionSite, which can use its task queue to make sure the
operations occur in a consistent order and on a clean runtime stack.

This CL is a followup to
https://src.chromium.org/viewvc/blink?view=revision&revision=149823 that makes
the rest of the operations in callTheAdoptionAgency asynchronous.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149849

[eseidel, 2013-05-07 00:11:37]

https://codereview.chromium.org/14759017/diff/1/Source/core/html/parser/HTMLC...
File Source/core/html/parser/HTMLConstructionSite.cpp (right):

https://codereview.chromium.org/14759017/diff/1/Source/core/html/parser/HTMLC...
Source/core/html/parser/HTMLConstructionSite.cpp:145: ContainerNode* oldParent =
static_cast<ContainerNode*>(task.child.get());
The only thing I would change here is making this private to the Task object. 
Then it can do the ASSERTing, etc.

https://codereview.chromium.org/14759017/diff/1/Source/core/html/parser/HTMLC...
Source/core/html/parser/HTMLConstructionSite.cpp:148: // Notice that we don't
need to manually attack the moved children
attack!

https://codereview.chromium.org/14759017/diff/1/Source/core/html/parser/HTMLC...
Source/core/html/parser/HTMLConstructionSite.cpp:157: if (task.operation ==
HTMLConstructionSiteTask::InsertAgain)
I would put a comment that these below this comment are only for the adoption
agency.

https://codereview.chromium.org/14759017/diff/1/Source/core/html/parser/HTMLC...
Source/core/html/parser/HTMLConstructionSite.cpp:595: void
HTMLConstructionSite::insertAgain(HTMLStackItem* newParent,
HTMLElementStack::ElementRecord* child)
Need a name so that folks have a prayer of knowing what this does.

https://codereview.chromium.org/14759017/diff/1/Source/core/html/parser/HTMLC...
File Source/core/html/parser/HTMLConstructionSite.h (right):

https://codereview.chromium.org/14759017/diff/1/Source/core/html/parser/HTMLC...
Source/core/html/parser/HTMLConstructionSite.h:44: InsertAgain,
InsertHarder?

[abarth-chromium, 2013-05-07 00:47:58]

PTAL

[eseidel, 2013-05-07 00:49:40]

lgtm

https://codereview.chromium.org/14759017/diff/5001/Source/core/html/parser/HT...
File Source/core/html/parser/HTMLConstructionSite.h (right):

https://codereview.chromium.org/14759017/diff/5001/Source/core/html/parser/HT...
Source/core/html/parser/HTMLConstructionSite.h:61: return
static_cast<ContainerNode*>(child.get());
I believe there is a toContainerNode() which does a RELEASE_ASSERT. :)

[commit-bot: I haz the power, 2013-05-07 00:53:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/14759017/11001

[commit-bot: I haz the power, 2013-05-07 01:54:23]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-07 04:33:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/14759017/20001

[commit-bot: I haz the power, 2013-05-07 05:08:55]

Change committed as 149849