Issue 14759008: Making the condition for showing signin in one click case more general.

Issue 14759008: Making the condition for showing signin in one click case more general. (Closed)

Created:
7 years, 7 months ago by jwd

Modified:
7 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Making the condition for showing signin in one click case more general. BUG=228976 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202621

Patch Set 2 : Removing an unused variable. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	chrome/browser/ui/sync/one_click_signin_helper.cc	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

lgtm Sorry for the delay Jesse. https://codereview.chromium.org/14759008/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/14759008/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode315 chrome/browser/ui/sync/one_click_signin_helper.cc:315: "ChromeLoginPrompt").ReplaceComponents(replacements); I think ...

7 years, 7 months ago (2013-05-10 16:52:13 UTC) #2

jwd

https://codereview.chromium.org/14759008/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc File chrome/browser/ui/sync/one_click_signin_helper.cc (right): https://codereview.chromium.org/14759008/diff/1/chrome/browser/ui/sync/one_click_signin_helper.cc#newcode315 chrome/browser/ui/sync/one_click_signin_helper.cc:315: "ChromeLoginPrompt").ReplaceComponents(replacements); On 2013/05/10 16:52:13, Roger Tawa wrote: > I ...

7 years, 7 months ago (2013-05-27 22:52:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/14759008/5001

7 years, 6 months ago (2013-05-28 14:05:09 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=119061

7 years, 6 months ago (2013-05-28 16:23:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jwd@chromium.org/14759008/5001

7 years, 6 months ago (2013-05-28 17:07:48 UTC) #6

Message was sent while issue was closed.

Change committed as 202621

Expand Messages | Collapse Messages