Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 14759008: Making the condition for showing signin in one click case more general. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removing an unused variable. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index 580749f0ce7b258e9a64e199996e303737b3007a..59fc87c678ae878306ee373281f2b81215e00769 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -338,13 +338,10 @@ bool AreWeShowingSignin(GURL url, SyncPromoUI::Source source,
GURL(GaiaUrls::GetInstance()->service_login_url()).ReplaceComponents(
replacements);
- GURL clean_one_click_url =
- GURL(GaiaUrls::GetInstance()->gaia_login_form_realm() +
- "ChromeLoginPrompt").ReplaceComponents(replacements);
-
return (url.ReplaceComponents(replacements) == clean_login_url &&
source != SyncPromoUI::SOURCE_UNKNOWN) ||
- (url.ReplaceComponents(replacements) == clean_one_click_url &&
+ (IsValidGaiaSigninRedirectOrResponseURL(url) &&
+ url.spec().find("ChromeLoginPrompt") != std::string::npos &&
!email.empty());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698