Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1475213002: update.py: Port remaining missing things from update.sh (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
hans
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

update.py: Port remaining missing things from update.sh * Build compiler-rt out-of-tree on linux and mac * Build android compiler-rt libs * Download gold plugin for official linux builds BUG=494442 Committed: https://crrev.com/8decfac8816ba6a976216b5c83ff6e79db928a4a Cr-Commit-Position: refs/heads/master@{#361930}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : tweak #

Patch Set 4 : rebase #

Patch Set 5 : package.py passes on linux #

Total comments: 1

Patch Set 6 : package.py mostly runs on os x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -37 lines) Patch
M tools/clang/scripts/update.py View 1 2 3 4 5 13 chunks +126 lines, -28 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 2 3 4 5 5 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
update.py still calls update.sh on non-Windows for now, but maybe not for too much longer. ...
5 years ago (2015-11-25 20:39:10 UTC) #2
hans
I didn't test it, but this looks right to me. lgtm https://codereview.chromium.org/1475213002/diff/80001/tools/clang/scripts/update.py File tools/clang/scripts/update.py (right): ...
5 years ago (2015-11-26 01:07:13 UTC) #4
Nico
I checked that package.py also mostly succeeds with this on OS X, I had to ...
5 years ago (2015-11-26 21:16:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475213002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475213002/100001
5 years ago (2015-11-26 21:17:36 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years ago (2015-11-26 22:49:50 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-26 22:50:28 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/8decfac8816ba6a976216b5c83ff6e79db928a4a
Cr-Commit-Position: refs/heads/master@{#361930}

Powered by Google App Engine
This is Rietveld 408576698