Changes to print preview layout.

Changes to print preview layout.

Modifies the print preview layout to better match the specs
for the new dialog style. This CL affects the layout for the
print preview even when the new dialog style is not used.

A close button will be added after we've switched to the new
dialog style, as the old style already has a close button in
the top right corner.

Spec: https://docs.google.com/a/google.com/folder/d/0B6x6iYCtKinEUTFOWUJFTWJFSTA/edit?docId=0B6x6iYCtKinERFBFenZxdlVCQUk
Before, old dialog style: http://i.imgur.com/8uDarV3.png
Before, new dialog style: http://i.imgur.com/QXdap6W.png
After, old dialog style: http://i.imgur.com/M0BaBy8.png
After, new dialog style: http://i.imgur.com/OFmL5tc.png

BUG=133363
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200459

[Mike Wittman, 2013-05-10 22:20:15]

Looking good.

This changes the internal styling of both the old and new style dialogs, and
will make it difficult to revert to the old style if necessary.  Is there an
easy way to retain the old styling?  If not we should pass this by Andrew.

Some layout comments:

- seems to be a little extra space between the "Total: x pages" label and the
top of the "Save" and "Cancel" buttons: 19px from baseline to top of button in
the mock vs. 23px in the dialog
- looks like there's too much space around the "Save as PDF" label; from the
separator above to the top of the "Change" button is 46px in the mocks, 51 px in
the dialog
- the "Change" button is too close to the lower separator by 7px
- the radio buttons are too far from the left side of the dialog by 6px (116px
vs. 110px)
- the spacing above and below the "Default" button is too small by 7px
- seems to be too much space between the "Selection only" label and the lower
seprator -- measured from the baseline: 16px in the mock vs. 20px in the dialog
- not enough space between the "Print using Google Cloud Print dialog..." label
and the separator above: 17px to text top-line in mock vs. 12px

[Rune Fevang, 2013-05-14 20:50:34]

On 2013/05/10 22:20:15, Mike Wittman wrote:
> Looking good.
> 
> This changes the internal styling of both the old and new style dialogs, and
> will make it difficult to revert to the old style if necessary.  Is there an
> easy way to retain the old styling?  If not we should pass this by Andrew.

Not that I'm aware of. It's possible to pass a flag to the page and go down
different paths depending on it, but in my opinion that's way too hairy for
something that will go away soon anyway. If we decide we want to go back we
could always just revert this change.
> 
> Some layout comments:
> 
> - seems to be a little extra space between the "Total: x pages" label and the
> top of the "Save" and "Cancel" buttons: 19px from baseline to top of button in
> the mock vs. 23px in the dialog

Fixed.

> - looks like there's too much space around the "Save as PDF" label; from the
> separator above to the top of the "Change" button is 46px in the mocks, 51 px
in
> the dialog

Fixed.

> - the "Change" button is too close to the lower separator by 7px

Fixed.

> - the radio buttons are too far from the left side of the dialog by 6px (116px
> vs. 110px)

It was 110 on linux aura. The difference is due to font differences, as it was
adjusted with a padding from the right end of the text. I changed it to be
either 20px from the text, or 110 pixels, whichever is greater.

> - the spacing above and below the "Default" button is too small by 7px

Fixed.

> - seems to be too much space between the "Selection only" label and the lower
> seprator -- measured from the baseline: 16px in the mock vs. 20px in the
dialog

Fixed.

> - not enough space between the "Print using Google Cloud Print dialog..."
label
> and the separator above: 17px to text top-line in mock vs. 12px

Changed the logic here a bit, but basically the difference is because the text
spans two lines in the screenshot vs one in the mock. A one-line link would line
up like the spec.

[Mike Wittman, 2013-05-15 23:21:21]

lgtm

[Rune Fevang, 2013-05-15 23:27:55]

Vitaly, could you do an OWNERS review please?

[Vitaly Buka (NO REVIEWS), 2013-05-16 00:20:20]

On 2013/05/15 23:27:55, Rune Fevang wrote:
> Vitaly, could you do an OWNERS review please?

Hi Rune, could you upload CL again, i see no side by side diffs.

[Rune Fevang, 2013-05-16 00:28:44]

On 2013/05/16 00:20:20, Vitaly Buka wrote:
> On 2013/05/15 23:27:55, Rune Fevang wrote:
> > Vitaly, could you do an OWNERS review please?
> 
> Hi Rune, could you upload CL again, i see no side by side diffs.

Done, seems to be working now.

[Vitaly Buka (NO REVIEWS), 2013-05-16 00:36:57]

lgtm

[commit-bot: I haz the power, 2013-05-16 00:46:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rfevang@chromium.org/14752026/28001

[commit-bot: I haz the power, 2013-05-16 05:28:41]

Change committed as 200459