Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 14752024: [Android] [RTL] Convert Left/Right attributes to Start/End attributes (Closed)

Created:
7 years, 7 months ago by Kibeom Kim (inactive)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[Android] [RTL] Convert Left/Right attributes to Start/End attributes We no longer need Left/Right attributes in favor of Start/End attributes since layout autogeneration crbug.com/235118 . BUG=239653

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M chrome/android/java/res/layout/autofill_dialog_title.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/autofill_editing_layout_credit_card.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/autofill_general_layout.xml View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/res/layout/autofill_menu_item.xml View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/res/layout/autofill_text.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/res/layout/js_modal_dialog.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/website_settings.xml View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/android/java/res/layout/month_picker.xml View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Kibeom Kim (inactive)
7 years, 7 months ago (2013-05-09 23:07:06 UTC) #1
newt (away)
lgtm
7 years, 7 months ago (2013-05-10 00:29:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/14752024/1
7 years, 7 months ago (2013-05-10 00:31:19 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=2317
7 years, 7 months ago (2013-05-10 00:39:36 UTC) #4
Kibeom Kim (inactive)
7 years, 7 months ago (2013-05-10 00:43:05 UTC) #5
newt (away)
I think Yaron is the only OWNER who's available right now
7 years, 7 months ago (2013-05-10 01:21:04 UTC) #6
David Trainor- moved to gerrit
lgtm
7 years, 7 months ago (2013-05-10 01:25:15 UTC) #7
David Trainor- moved to gerrit
I'm not an owner on content. You'll need Yaron for that I think.
7 years, 7 months ago (2013-05-10 01:25:43 UTC) #8
Kibeom Kim (inactive)
7 years, 7 months ago (2013-05-10 01:26:03 UTC) #9
Yaron
lgtm
7 years, 7 months ago (2013-05-10 17:26:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/14752024/1
7 years, 7 months ago (2013-05-10 17:29:35 UTC) #11
commit-bot: I haz the power
Failed to apply the patch. Sending chrome/android/java/res/layout/autofill_dialog_title.xml Sending chrome/android/java/res/layout/autofill_editing_layout_credit_card.xml Sending chrome/android/java/res/layout/autofill_general_layout.xml Sending chrome/android/java/res/layout/autofill_menu_item.xml Sending chrome/android/java/res/layout/autofill_text.xml ...
7 years, 7 months ago (2013-05-10 20:25:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/14752024/1
7 years, 7 months ago (2013-05-10 21:48:22 UTC) #13
commit-bot: I haz the power
Failed to apply patch for chrome/android/java/res/layout/autofill_dialog_title.xml: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-10 21:48:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/14752024/20001
7 years, 7 months ago (2013-05-10 21:52:26 UTC) #15
commit-bot: I haz the power
Failed to apply patch for chrome/android/java/res/layout/autofill_dialog_title.xml: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-10 21:52:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/14752024/20001
7 years, 7 months ago (2013-05-10 23:30:58 UTC) #17
commit-bot: I haz the power
Failed to apply patch for chrome/android/java/res/layout/autofill_dialog_title.xml: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-10 23:31:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/14752024/20001
7 years, 7 months ago (2013-05-12 02:05:33 UTC) #19
commit-bot: I haz the power
Failed to apply patch for chrome/android/java/res/layout/autofill_dialog_title.xml: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-12 02:05:36 UTC) #20
Kibeom Kim (inactive)
7 years, 7 months ago (2013-05-12 03:48:54 UTC) #21
Wow, this is really weird. It is not committed according to this page, and I can
still click "commit: [checkbox]" but it's already merged on the trunk.

git log -1 65a1476b5f7ecbc84ea58b2de9bcb5c574043f5d

commit 65a1476b5f7ecbc84ea58b2de9bcb5c574043f5d
Author: kkimlabs@chromium.org
<kkimlabs@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date:   Fri May 10 20:11:31 2013 +0000

    [Android] [RTL] Convert Left/Right attributes to Start/End attributes
    
    We no longer need Left/Right attributes in favor of Start/End attributes
    since layout autogeneration crbug.com/235118 .
    
    BUG=239653
    
    Review URL: https://chromiumcodereview.appspot.com/14752024
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199525
0039d316-1c4b-4281-b951-d872f2087c98

Powered by Google App Engine
This is Rietveld 408576698