Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: syzygy/refinery/symbols/symbol_provider.h

Issue 1475083002: [Refinery] Introduce TypePropagatorAnalyzer - pointer types. (Closed) Base URL: https://github.com/google/syzygy.git@master
Patch Set: Final nit Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « syzygy/refinery/symbols/dia_symbol_provider.h ('k') | syzygy/refinery/types/type_repository.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: syzygy/refinery/symbols/symbol_provider.h
diff --git a/syzygy/refinery/symbols/symbol_provider.h b/syzygy/refinery/symbols/symbol_provider.h
index 9e88158e093123b07afc46a77ea9aae1c1a193c7..a337390a4316cfd1a8b8617f9b27766efb8e4e34 100644
--- a/syzygy/refinery/symbols/symbol_provider.h
+++ b/syzygy/refinery/symbols/symbol_provider.h
@@ -32,10 +32,13 @@ class ProcessState;
// The SymbolProvider provides symbol information. See DiaSymbolProvider for an
// alternative.
+// TODO(manzagop): get rid of the functions that take in a process state. The
+// symbol provider shouldn't offer that service.
class SymbolProvider : public base::RefCounted<SymbolProvider> {
public:
SymbolProvider();
- ~SymbolProvider();
+ // @note virtual to enable mocking.
+ virtual ~SymbolProvider();
// Retrieves or creates a TypeRepository for the module within @p
// process_state corresponding to @p va.
@@ -51,13 +54,15 @@ class SymbolProvider : public base::RefCounted<SymbolProvider> {
// Retrieves or creates a TypeRepository for the module corresponding to @p
// signature.
+ // @note virtual to enable mocking.
// @param signature the signature of the module for which to get a type
// repository.
// @param type_repo on success, returns a type repository for the module. On
// failure, contains nullptr.
// @returns true on success, false on failure.
- bool FindOrCreateTypeRepository(const pe::PEFile::Signature& signature,
- scoped_refptr<TypeRepository>* type_repo);
+ virtual bool FindOrCreateTypeRepository(
+ const pe::PEFile::Signature& signature,
+ scoped_refptr<TypeRepository>* type_repo);
// Retrieves or creates a TypeNameIndex for the module within @p
// process_state corresponding to @p va.
« no previous file with comments | « syzygy/refinery/symbols/dia_symbol_provider.h ('k') | syzygy/refinery/types/type_repository.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698